-
Notifications
You must be signed in to change notification settings - Fork 157
Allow fast_float to parse strings accepted by the Fortran internal read function. #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
/* | ||
* Exercise the Fortran conversion option. | ||
*/ | ||
#include <cstdlib> | ||
#include <iostream> | ||
#include <vector> | ||
|
||
#define FASTFLOAT_ALLOWS_LEADING_PLUS | ||
|
||
#include "fast_float/fast_float.h" | ||
|
||
int main () | ||
{ | ||
const std::vector<double> expected{ 10000, 1000, 100, 10, 1, .1, .01, .001, .0001 }; | ||
const std::vector<std::string> fmt1{ "1+4", "1+3", "1+2", "1+1", "1+0", "1-1", "1-2", | ||
"1-3", "1-4" }; | ||
const std::vector<std::string> fmt2{ "1d+4", "1d+3", "1d+2", "1d+1", "1d+0", "1d-1", | ||
"1d-2", "1d-3", "1d-4" }; | ||
const std::vector<std::string> fmt3{ "+1+4", "+1+3", "+1+2", "+1+1", "+1+0", "+1-1", | ||
"+1-2", "+1-3", "+1-4" }; | ||
const fast_float::parse_options options{ fast_float::chars_format::fortran }; | ||
|
||
for ( auto const& f : fmt1 ) { | ||
auto d{ std::distance( &fmt1[0], &f ) }; | ||
double result; | ||
auto answer{ fast_float::from_chars_advanced( f.data(), f.data()+f.size(), result, | ||
options ) }; | ||
if ( answer.ec != std::errc() || result != expected[std::size_t(d)] ) { | ||
std::cerr << "parsing failure on " << f << std::endl; | ||
return EXIT_FAILURE; | ||
} | ||
} | ||
|
||
for ( auto const& f : fmt2 ) { | ||
auto d{ std::distance( &fmt2[0], &f ) }; | ||
double result; | ||
auto answer{ fast_float::from_chars_advanced( f.data(), f.data()+f.size(), result, | ||
options ) }; | ||
if ( answer.ec != std::errc() || result != expected[std::size_t(d)] ) { | ||
std::cerr << "parsing failure on " << f << std::endl; | ||
return EXIT_FAILURE; | ||
} | ||
} | ||
|
||
for ( auto const& f : fmt3 ) { | ||
auto d{ std::distance( &fmt3[0], &f ) }; | ||
double result; | ||
auto answer{ fast_float::from_chars_advanced( f.data(), f.data()+f.size(), result, | ||
options ) }; | ||
if ( answer.ec != std::errc() || result != expected[std::size_t(d)] ) { | ||
std::cerr << "parsing failure on " << f << std::endl; | ||
return EXIT_FAILURE; | ||
} | ||
} | ||
|
||
return EXIT_SUCCESS; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line would match chars_format::general as well, allowing 'd' and 'D' even in non-fortran mode.
eg. general = 0b101, fortran = 0b10101, general & fortran = 0b101 which evaluates to true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm… that’s not good. We need to fix this mistake.