Add support for parsing numbers according to JSON format #220
Conversation
|
Looks like a good idea. I will review and I expect to merge. |
include/fast_float/float_common.h
Outdated
| @@ -16,6 +16,7 @@ enum chars_format { | |||
| scientific = 1 << 0, | |||
| fixed = 1 << 2, | |||
| hex = 1 << 3, | |||
| json = 1 << 4 | fixed | scientific, | |||
There was a problem hiding this comment.
Obviously, this will cause a conflict with #219
but that's not a big issue.
tests/json_fmt.cpp
Outdated
|
|
||
| int main() | ||
| { | ||
| const std::vector<double> expected{ -0.2, 0.02, 0.002, 1., 0. }; |
There was a problem hiding this comment.
Both 1. and 0. are fine, but my expectation is that you could use 1 and 0. (This is not a request for you to change the code, just a comment.)
|
@mayawarrier I think that the JSON format does not allow a leading |
Got it, I'll just ignore the FASTFLOAT_ALLOWS_LEADING_PLUS macro when the runtime format is json. |
- Most JSON parsers offer this option too
|
I disallowed leading pluses as requested. I also added an option to allow inf/nan in JSON mode. This is a common option in JSON parsers despite not being part of the standard. |
|
I am sure that this could be perfected, but it looks solid to me, merging. |
Details on the format are available here (RFC 8259): https://datatracker.ietf.org/doc/html/rfc8259#section-6
This is compatible with previous JSON RFCs as well as the number format hasn't changed.