Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enum class chars_format #279

Merged
merged 2 commits into from
Nov 20, 2024
Merged

enum class chars_format #279

merged 2 commits into from
Nov 20, 2024

Conversation

dalle
Copy link
Collaborator

@dalle dalle commented Nov 20, 2024

Changed chars_format to an enum class.
Added operators to comply to BitmaskType.

Fixes #278

@lemire
Copy link
Member

lemire commented Nov 20, 2024

@dalle What would you think about specifying uint64_t as the underlying type and casting to uint64_t? As the code currently stand, it would make no difference, but I tend to prefer fixed-size integers (for easier portability).

@dalle
Copy link
Collaborator Author

dalle commented Nov 20, 2024

I'm all for it. uint32 or uint64?

@lemire
Copy link
Member

lemire commented Nov 20, 2024

I'm all for it. uint32 or uint64?

I usually default on uint64_t in such cases. Going for 32 bits saves nothing in this case.

@lemire
Copy link
Member

lemire commented Nov 20, 2024

Merging.

@lemire lemire merged commit 724834f into fastfloat:main Nov 20, 2024
37 checks passed
@dalle dalle deleted the issue278-scoped-enum branch November 23, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make fast_float::chars_format a scoped enumeration
2 participants