Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge next into main #92

Merged
merged 4 commits into from
Jun 23, 2024
Merged

Merge next into main #92

merged 4 commits into from
Jun 23, 2024

Conversation

jsumners
Copy link
Member

As titled.

gurgunday and others added 4 commits April 13, 2024 11:34
@gurgunday
Update for v5 (#80)
8428052 
* update

* up
@gurgunday
workflows: update and pin node LTS versions (#81)
88cb871 
* update workflow

* start from 16
@gurgunday
Merge branch 'main' of https://github.com/fastify/fast-uri into next
14b617f
@kurtextrem @gurgunday
perf: make ipv4 regex faster (#73)
787a904 
* perf: make ipv4 regex faster

All credits for this regex to https://stackoverflow.com/a/36760050. 

The regex is both more correct and faster (https://esbench.com/bench/6532596e7ff73700a4debb6a).
Examples:
previous regex recognized "01.01.01.01" or "1.1.000.1" as correct ipv4 regex, but those aren't valid as per https://datatracker.ietf.org/doc/html/rfc5954#section-4.1.

* avoid capture groups

* update to fastest regexp variant

* comment out 10.10.000.1110

* lint

---------

Signed-off-by: Jacob Groß <[email protected]>
Co-authored-by: Gürgün Dayıoğlu <[email protected]>
mcollina
mcollina approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

You can release a major for this directly

gurgunday
gurgunday approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

Given our goals of having this as the default of ajv, I think we would need to support a wide range of node versions.

We might consider instead to switch to tape.

@jsumners jsumners merged commit 8dea240 into main Jun 23, 2024
42 checks passed
@jsumners jsumners deleted the next branch June 23, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsumners @mcollina @gurgunday @kurtextrem