Don't remove extension in links #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was breaking relative links when a trailing slash is included in the current URL. If the file extension is included, then Docusaurus can convert the links to have absolute URLs, so the trailing slash in the current URL doesn't matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't remove the
.mdextension from markdown links since this prevents docusaurus from converting the link to an absolute URL, causing #157.See also docusaurus docs on Markdown links.
I also added
trailingSlash: trueto the docusaurus config so that internal links have trailing slashes, which aligns with the Github Pages behavior of redirecting with a trailing slash.Related Issues
Fixes #157
Check List