Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build static datasources #45

Merged
merged 5 commits into from
Jan 15, 2023
Merged

feat: build static datasources #45

merged 5 commits into from
Jan 15, 2023

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Jan 11, 2023

Relates to #46

TODO:

  • generate plugins.json at build time
  • generate benchmarks.json at build time - requires Benchmark page #43
  • generate team.json at build time
  • generate organizations.json at build time
  • generate acknowledgements.json at build time

@Eomm Eomm marked this pull request as ready for review January 15, 2023 10:30
@Eomm
Copy link
Member Author

Eomm commented Jan 15, 2023

cc @HassanBahati this PR generates these files that are useful for your index PR #38

  • static/generated/organisations.json
  • static/generated/team.json
  • static/generated/acknowledgements.json

@Eomm Eomm merged commit 23da498 into main Jan 15, 2023
@Eomm Eomm deleted the integrations branch January 15, 2023 10:47
@HassanBahati
Copy link
Contributor

cc @HassanBahati this PR generates these files that are useful for your index PR #38

* static/generated/organisations.json

* static/generated/team.json

* static/generated/acknowledgements.json

this is noted. let me pull the changes

@@ -0,0 +1,251 @@
- name: '2hire'
Copy link
Contributor

@HassanBahati HassanBahati Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eomm am just curious...what could be the upside of having this data in .yml versus .json given that Prevously we had them in json

Copy link
Contributor

@HassanBahati HassanBahati Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've seen a script that generates the .json files....what could be the intent in first having yml then run a script to generate json

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this way we don't need to update pages/documentation across the organization - it is just another piece of the old website legacy that we could remove after the migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants