fix: preserve utf8 multibyte characters split across chunks in XmlTransformStream #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where multibyte utf8 characters like ö or emojis would get corrupted if their byte sequence was split across multiple stream chunks.
Previously the
XmlTransformStream
usedtextDecoder.decode(chunk)
per chunk. If a multibyte char was split across chunks the decoder would treat an incomplete sequence as invalid and replace it with a replacement charU+FFFD (�)
The fix is to call
textDecoder.decode(chunk, { stream: true })
which tells the decoder to buffer incomplete sequences between chunks.The final
textDecoder.decode()
in flush emits any buffered sequencesBefore:
ö��ö
After:
ööö
links: