Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test_activations less sensitive to random seed values #1211

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmitrevs
Copy link
Contributor

Description

This rounds the inputs in test_activations in test_pytorch_api.py so that the input values are the same for both the pytorch and hls4ml models. This should decrease the sensitivity to random numbers, which caused for example, the test failure in #1200.

Type of change

  • Other (Specify) - pytest robustness

Tests

Hopefully the pytest will no longer fail apparently randomly.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@jmitrevs jmitrevs requested a review from JanFSchulte February 28, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant