♿️(fix) styles and template tweaks #276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing the external links tweak |
Some font-size and styles were not in accordance with AMA standards. Blogpost template was changed to have only one h1 instead of two.
sandroscosta
force-pushed
the
sandroscosta/a11y/external-links
branch
from
1b1ab56 to
a59c0ba
Compare
Add external link arrow svg for visually distinguish external links
|
External links |
igobranco
requested changes
Nov 28, 2024
Comment on lines
+65
to
+66
| a[href*="//"]:not([href*="nau.edu.pt"]), | ||
| a[target="_blank"] { |
There was a problem hiding this comment.
Having nau.edu.pt hardcoded seams not a good solution, please remove it.
a[href*="//"]:not([href*="nau.edu.pt"]),Having a special case for target _blank cases is ok. I tried adding for all site but isn't practical, because of the social sharing stuff.
a[target="_blank"]But having the same code repeated N times isn't a good solution.
Can you create a scss function/mixin and add it to the places that need to have that special arrow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some font-size and styles were not in accordance with AMA standards.
Blogpost template was changed to have only one h1 instead of two.
Minor tweaks to heading margins for better reading.
Minor tweaks to footer link padding for 44px minimum height.
https://github.com/fccn/nau-technical/issues/323