feat: Provide callback function for threaded cache refresh failures #5124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Barnett <[email protected]>
Signed-off-by: Zach Barnett <[email protected]>
ntkathole
reviewed
Mar 7, 2025
| def refresh_loop(): | ||
| while not self._stop_event.is_set(): | ||
| try: | ||
| time.sleep(cache_ttl_seconds) |
There was a problem hiding this comment.
Suggested change
| time.sleep(cache_ttl_seconds) | |
| self._stop_event.wait(cache_ttl_seconds) |
Signed-off-by: Zach Barnett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The previous implementation of
_start_thread_async_refreshwas constantly creating new background threads to handle refreshing the cache. This exposed the possibility of running into aRuntime Error: Can't start new threadwhen attempting to start one, leading to no refresh thread running and causing a stale cache.We are switching to keeping the same thread running, but using
self._stop_event.wait(cache_ttl_seconds)to control when a refresh occurs.We are also introducing a callback function that is passed through
SqlRegistrytoCachingRegistry, which allows users to be notified whenever cache refreshes fail, and handle them in whatever way they want.Which issue(s) this PR fixes:
Misc
@EXPEbdodla