feat: Operator mounts the odh-trusted-ca-bundle configmap when deployed on RHOAI or ODH #5169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchughesiv
reviewed
Mar 20, 2025
infra/feast-operator/internal/controller/services/services_types.go
Outdated
Show resolved
Hide resolved
redhatHameed
force-pushed
the
odh-trusted-ca-bundle
branch
from
225c491 to
5ab265e
Compare
tchughesiv
reviewed
Mar 21, 2025
redhatHameed
force-pushed
the
odh-trusted-ca-bundle
branch
from
5ab265e to
fda90ed
Compare
|
The code LGTM but I think you should add the basic tests with caBundle present and without assertions |
…ed on RHOAI or ODH Signed-off-by: Abdul Hameed <[email protected]>
redhatHameed
force-pushed
the
odh-trusted-ca-bundle
branch
from
fda90ed to
44a3166
Compare
Thanks for reviewing added tests |
|
lgtm |
|
@tchughesiv can I get approval on this. Thanks |
tchughesiv
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator searches for the
odh-trusted-ca-bundleConfigMap and mounts it into the Feast containers. In case the standalone feast operator is deployed and the ConfigMap is not present, the operator will not mount it.This change is required when the Feast operator is deployed with ODH or RHOAI.
example of volume mount.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Misc