Skip to content

Commit

Permalink
Merge branch 'master' into 2-1
Browse files Browse the repository at this point in the history
  • Loading branch information
illright committed Sep 28, 2024
2 parents 15ae4b4 + faa602a commit eacc66e
Show file tree
Hide file tree
Showing 13 changed files with 27 additions and 14 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [2.0.0] - 2023-10-01

> **Note**
> This release note is retrospective, meaning that prior to this release, the Feature-Sliced Design project did not keep a changelog. Below is a summary of the most prominent recent changes, but there is no FSD v1. Prior to FSD, there has been a project called ["Feature Slices"](https://featureslices.dev/v1.0.html), and it is considered to be the v1 of FSD.
> This release note is retrospective, meaning that prior to this release, the Feature-Sliced Design project did not keep a changelog. Below is a summary of the most prominent recent changes, but there is no FSD v1. Prior to FSD, there has been a project called ["Feature Slices"](https://feature-sliced.github.io/featureslices.dev/v1.0.html), and it is considered to be the v1 of FSD.
### Deprecated

Expand Down
4 changes: 2 additions & 2 deletions config/docusaurus/navbar.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ const navbar = {
dropdownActiveClassDisabled: true,
dropdownItemsAfter: [
{
to: "https://featureslices.dev/v1.0.html",
to: "https://feature-sliced.github.io/featureslices.dev/v1.0.html",
label: "v1.0",
},
{
to: "https://featureslices.dev/v0.1.html",
to: "https://feature-sliced.github.io/featureslices.dev/v0.1.html",
label: "v0.1",
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ Now it is much easier to [observe the principle of low coupling][refs-low-coupli
[refs-low-coupling]: /docs/reference/isolation/coupling-cohesion
[refs-adaptability]: /docs/about/understanding/naming

[ext-v1]: https://featureslices.dev/v1.0.html
[ext-v1]: https://feature-sliced.github.io/featureslices.dev/v1.0.html
[ext-tg-spb]: https://t.me/feature_slices
[ext-fdd]: https://github.com/feature-sliced/documentation/tree/rc/feature-driven
[ext-fdd-issues]: https://github.com/kof/feature-driven-architecture/issues
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ The layers Shared and App don't contain slices. That is because Shared should co

Slices are meant to be independent and highly cohesive groups of code files. The graphic below might help to visualize the tricky concepts of _cohesion_ and _coupling_:

<figure>
<img alt="coupling-cohesion-themed" src="/img/coupling.png" width="80%" />

<figure>
<img src="/img/coupling-cohesion-light.svg#light-mode-only" alt="" />
<img src="/img/coupling-cohesion-dark.svg#dark-mode-only" alt="" />
<figcaption>
Source: https://enterprisecraftsmanship.com/posts/cohesion-coupling-difference/
Image inspired by https://enterprisecraftsmanship.com/posts/cohesion-coupling-difference/
</figcaption>
</figure>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ sidebar_position: 4
[refs-low-coupling]: /docs/reference/isolation/coupling-cohesion
[refs-adaptability]: /docs/about/understanding/naming

[ext-v1]: https://featureslices.dev/v1.0.html
[ext-v1]: https://feature-sliced.github.io/featureslices.dev/v1.0.html
[ext-tg-spb]: https://t.me/feature_slices
[ext-fdd]: https://github.com/feature-sliced/documentation/tree/rc/feature-driven
[ext-fdd-issues]: https://github.com/kof/feature-driven-architecture/issues
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,13 @@ sidebar_position: 1

Модули приложения должны проектироваться как обладающие **сильной связностью** (направленные на решение одной четкой задачи) и **слабой зацепленностью** (как можно менее зависимые от других модулей)

![coupling-cohesion-themed](/img/coupling.png)
<figure>
<img src="/img/coupling-cohesion-light.svg#light-mode-only" alt="" />
<img src="/img/coupling-cohesion-dark.svg#dark-mode-only" alt="" />
<figcaption>
Иллюстрация вдохновлена статьей https://enterprisecraftsmanship.com/posts/cohesion-coupling-difference/
</figcaption>
</figure>

В рамках методологии это достигается через:

Expand Down
5 changes: 5 additions & 0 deletions src/app/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,8 @@ h6 {
border-radius: var(--ifm-button-border-radius) !important;
}
}

.theme-back-to-top-button {
// The PushFeedback button is positioned in the same place, so we need to move the "back to top" button higher
bottom: 3.5rem !important;
}
2 changes: 1 addition & 1 deletion src/features/feedback/doc/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export function FeedbackWidget({ projectId }: { projectId: string }) {
rating-stars-placeholder={translate({
id: "features.feedback-doc.rating-stars-placeholder",
})}
button-position="center-right"
button-position="bottom-right"
button-style="dark"
modal-position="bottom-right"
custom-font="true"
Expand Down
2 changes: 1 addition & 1 deletion src/features/hero/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export function Hero() {
<div className="margin-top--md">
<Link
className={styles.link}
to="https://featureslices.dev/"
to="https://feature-sliced.github.io/featureslices.dev/v1.0.html"
>
{translate({ id: "features.hero.previous" })}{" "}
(feature-slices@v1)
Expand Down
4 changes: 2 additions & 2 deletions src/pages/versions/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,12 @@ function Version() {
<Table>
<Table.Row
th="v1.0"
href="https://featureslices.dev/v1.0.html"
href="https://feature-sliced.github.io/featureslices.dev/v1.0.html"
hrefTitle="Documentation"
/>
<Table.Row
th="v0.1"
href="https://featureslices.dev/v0.1.html"
href="https://feature-sliced.github.io/featureslices.dev/v0.1.html"
hrefTitle="Documentation"
/>
</Table>
Expand Down
1 change: 1 addition & 0 deletions static/img/coupling-cohesion-dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions static/img/coupling-cohesion-light.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed static/img/coupling.png
Binary file not shown.

0 comments on commit eacc66e

Please sign in to comment.