Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new example #707

Merged
merged 3 commits into from
Aug 11, 2024
Merged

Add new example #707

merged 3 commits into from
Aug 11, 2024

Conversation

sanua356
Copy link
Contributor

Hello everyone! I suggest adding a mini-game to the documentation, since there are currently no projects in the game development area. The linter "staiger" was launched before the creation of the PR, no errors were found.

Game repository: https://github.com/sanua356/tiny-bunny
View demo: https://sanua356.github.io/tiny-bunny/

Copy link

netlify bot commented Aug 10, 2024

Deploy Preview for pr-fsd ready!

Name Link
🔨 Latest commit 1ba3db3
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/66b8ba14b319a50008195f29
😎 Deploy Preview https://deploy-preview-707--pr-fsd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@illright
Copy link
Member

Hey, thanks for the example, looks really cool! I noticed that you have a typo in the folder name "entities", that could lead Steiger to miss some files, could you fix it and run the linter again please?

@sanua356
Copy link
Contributor Author

@illright
Yes. I renamed the entities folder to the correct type and fixed a small number of new errors in "steiger" after the renaming. The linter now reports no errors.
image

@illright
Copy link
Member

I'm a bit unsure about the hatchButtons entity. It's just a UI component without any business logic, so I'd suggest putting it in shared/ui instead. The rest is pretty good!

@sanua356
Copy link
Contributor Author

I agree. Earlier, when the prototype of the application was just emerging, this component contained logic, so it was on this layer. I have already transferred it to "shared/ui". I launched the linter, no errors appeared.

@illright
Copy link
Member

Could you please move your example from the first position in the array of examples to the last? Otherwise it appears at the end of the list, not in the beginning

@sanua356
Copy link
Contributor Author

Okay. No problem. 3 minutes.

@sanua356
Copy link
Contributor Author

Done

Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illright illright merged commit e6aeb31 into feature-sliced:master Aug 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants