Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add/remove website urls in examples #709

Merged
merged 3 commits into from
Aug 17, 2024
Merged

fix: add/remove website urls in examples #709

merged 3 commits into from
Aug 17, 2024

Conversation

sanua356
Copy link
Contributor

Hi everyone! I looked through all the examples in the documentation and found that some of the website links were broken, and some were in the repository but not listed in the documentation. I fixed that.

  • MokeSmoke (add website)
  • Sudoky Effector (remove website)

Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for pr-fsd ready!

Name Link
🔨 Latest commit ff84b0e
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/66bc1d59bbcbe700080c01d4
😎 Deploy Preview https://deploy-preview-709--pr-fsd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@illright
Copy link
Member

The Sudoku website works for me. Also, could you remove the /ru prefix in Moke-Smoke? We don't have internationalization of examples yet, and our docs are English-first

@sanua356
Copy link
Contributor Author

No problem. The "/ru" prefix has been removed from MokeSmoke. But there is a problem with sudoku. It does not open from Russian IPs (only via VPN). Perhaps it is worth leaving a notification about this in the page interface.

@illright
Copy link
Member

illright commented Aug 13, 2024

Perhaps it is worth leaving a notification about this in the page interface.

Ideally, we'd have that, but I wouldn't wanna spend much time on the current examples page, there's a lot to be desired anyway

Could you please fix the linting issues as well? Oh, and I'd prefer to have the link to Sudoku anyway, for those who use a VPN

@sanua356
Copy link
Contributor Author

@illright Yes. I`am fix lint warnings and return sudoku link in config file. As a result, the PR now contains only the addition of the mokeSmoke website to the config file.

@illright illright merged commit 96309bb into feature-sliced:master Aug 17, 2024
6 checks passed
@illright
Copy link
Member

Thanks for keeping an eye out for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants