Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: translate get-started folder index, overview to Korean #715

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

movie42
Copy link
Contributor

@movie42 movie42 commented Aug 30, 2024

Hello.
I've been applying FSD to my project recently. FSD has been very helpful to me.
In particular, I had experience with dependencies becoming entangled in previous projects, and I think the biggest advantage of FSD might be its ability to isolate business logic.

Background

While studying, I thought I'd like to contribute by translating the documentation into Korean.
This translation was completed with the assistance of AI. However, I personally reviewed it, refining or paraphrasing parts that were too literal, unnatural, or unclear in conveying the intended meaning. Throughout the translation, I avoided using slang and maintained formal expressions.

Changelog

  • add flag kr in i18n.js
  • add scripts kr in package.json
  • translate get-started index file to kr
  • translate overview to kr
스크린샷 2024-08-30 오전 10 36 01

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for pr-fsd ready!

Name Link
🔨 Latest commit 7f6f270
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/66d5ad0c083a640008c58fa8
😎 Deploy Preview https://deploy-preview-715--pr-fsd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@illright
Copy link
Member

illright commented Sep 1, 2024

Hi, thanks a lot! Translating the docs is super important, I'm very glad that you took on this. I'll review it to the best of my abilities

@illright
Copy link
Member

illright commented Sep 1, 2024

I looked over it, seems nice, the only thing is the home page has missing strings. Could you fill those in as well?

https://deploy-preview-715--pr-fsd.netlify.app/kr/

image

@movie42 movie42 force-pushed the feat/translate-korean branch from 00db60c to b93eb78 Compare September 2, 2024 12:11
- add flag kr in i18n.js
- add scripts kr in package.json
- translate get-started index file to kr
- translate overview to kr
@movie42 movie42 force-pushed the feat/translate-korean branch from b93eb78 to 7f6f270 Compare September 2, 2024 12:18
@movie42
Copy link
Contributor Author

movie42 commented Sep 2, 2024

Thank you for the review.

I confirmed that the broken part was also visible in local development, and I added code.json to fix it.

However, I couldn't verify the fix in the Netlify preview. It seems that the commit I made hasn't been deployed.

I went through all the pages to check if there were any other broken parts, but compared to the deployed pages, it looks like there aren't any other broken sections.

Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you like to have a Korean-language thread in our Telegram chat, by the way?

@illright illright merged commit 7149119 into feature-sliced:master Sep 2, 2024
6 checks passed
@movie42
Copy link
Contributor Author

movie42 commented Sep 3, 2024

Thank you.
But This doesn't represent the opinion of all Koreans, but Telegram has somewhat lower utility in Korea. I know there's a Discord channel, so could you create a Korean language channel there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants