Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: guides page translated into Korean #732

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

Gaic4o
Copy link
Contributor

@Gaic4o Gaic4o commented Oct 7, 2024

Background

I have translated the Guide page into Korean.

If you think there are aspects that need improvement, please let me know, and I would be happy to make the adjustments. Thank you!

I have requested a Korean translation review from one reviewer in the FSD Discord Korean community to ensure that my Korean writing is well done. I would appreciate it if you could merge it after the review is completed.

Changelog

image

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for pr-fsd ready!

Name Link
🔨 Latest commit c077800
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/670602be3cf44100087a9c8b
😎 Deploy Preview https://deploy-preview-732--pr-fsd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gaic4o Gaic4o requested a review from Chun-gu October 9, 2024 04:13
Copy link

@Chun-gu Chun-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 반영 감사합니다.

프레임워크 및 라이브러리별 사용 가이드에 원문에 없는 tags를 추가하셨지만 레이아웃이 깨지진 않을 것 같아 일단 approve 하겠습니다.

고생하셨습니다.

@illright
Copy link
Member

illright commented Oct 9, 2024

@Gaic4o is it ready for my review?

@Gaic4o
Copy link
Contributor Author

Gaic4o commented Oct 10, 2024

@illright Discord's Korean translation review has been completed, so the administrator can review or merge it.

Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good to go :)

@illright illright merged commit 39ae10f into feature-sliced:master Oct 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants