Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: examples Authentication page translated into Korean #736

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

Gaic4o
Copy link
Contributor

@Gaic4o Gaic4o commented Oct 14, 2024

I have translated the examples Authentication page into Korean.

If you think there are aspects that need improvement, please let me know, and I would be happy to make the adjustments. Thank you!

I have requested a Korean translation review from one reviewer in the FSD Discord Korean community to ensure that my Korean writing is well done. I would appreciate it if you could merge it after the review is completed.

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for pr-fsd ready!

Name Link
🔨 Latest commit 2ff4fb5
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/671e68ee5001fe0009a88f6f
😎 Deploy Preview https://deploy-preview-736--pr-fsd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gaic4o Gaic4o changed the title feat: examples Authentication page translated into Korean docs: examples Authentication page translated into Korean Oct 14, 2024
Copy link
Contributor

@movie42 movie42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역 고생하셨습니다!

Copy link
Contributor

@movie42 movie42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영하신거 확인했습니다. 감사합니다!

@Gaic4o
Copy link
Contributor Author

Gaic4o commented Oct 28, 2024

@illright I have addressed all the feedback revisions and have uploaded the revised documents.

Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone!

@illright illright merged commit f174b70 into feature-sliced:master Oct 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants