Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: from-v1 page translated into Korean #751

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gaic4o
Copy link
Contributor

@Gaic4o Gaic4o commented Nov 7, 2024

Background

We translated the Using with from-v1 page.

If you think there are aspects that need improvement, please let me know, and I would be happy to make the adjustments. Thank you!

I have requested a Korean translation review from one reviewer in the FSD Discord Korean community to ensure that my Korean writing is well done. I would appreciate it if you could merge it after the review is completed.

Copy link

netlify bot commented Nov 7, 2024

👷 Deploy request for pr-fsd pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 1e7d4b6

Copy link
Contributor

@movie42 movie42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역해주셔서 감사합니다 👍


#### 🔍 더 직관적이고 간단한 아키텍처

v2 방법론은 **더 직관적이고 공통적인 추상화를 제공하여 개발자가 로직을 분리하는 작업을 쉽게 합니다.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
v2 방법론은 **더 직관적이고 공통적인 추상화를 제공하여 개발자가 로직을 분리하는 작업을 쉽게 합니다.**
v2 방법론은 **더 직관적이고 일반적인 추상화를 제공하여 개발자가 로직 분리를 쉽게 할 수 있게 합니다.**
  • 공통적인보다 일반적인은 어떠신가요?
  • '개발자가 로직을 분리하는 작업을 쉽게 합니다.'라는 문장이 표현이 중의적이라 조금더 문장을 명확하게 수정하면 좋을 것 같습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요! 피드백 감사합니다.

@Gaic4o Gaic4o requested a review from movie42 November 24, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants