Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: about mission page translated into Korean #754

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

Gaic4o
Copy link
Contributor

@Gaic4o Gaic4o commented Nov 11, 2024

Background

We translated the Using with about mission page.

If you think there are aspects that need improvement, please let me know, and I would be happy to make the adjustments. Thank you!

I have requested a Korean translation review from one reviewer in the FSD Discord Korean community to ensure that my Korean writing is well done. I would appreciate it if you could merge it after the review is completed.

Copy link

netlify bot commented Nov 11, 2024

👷 Deploy request for pr-fsd accepted.

Name Link
🔨 Latest commit 5422c1d
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/673213d847541900082485d4

Copy link
Contributor

@movie42 movie42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역 감사합니다.

두 부분에서 제안을 드립니다. 하지만 그 부분이 전체 내용을 이해하는데는 어려움을 주는 것은 아니기 때문에 어푸 드렸습니다.


## 목표

### 다양한 개발자들이 쉽게 이해할 수 있는 직관적 명확성
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다양한이 복수 의미를 가지고 있기 때문에 다양한 개발자에게 라고 표현할 수 있습니다.
쉽게와 직관적은 의미가 상호 보완적이기 때문에 아래 문장도 제안드립니다.

  • 다양한 개발자에게 쉽고 명확하게
  • 다양한 개발자에게 직관적이고 명확하게

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!


이를 통해 개발자들은 아키텍처와 개발상의 오랜 문제를 우회할 수 있는 검증된 접근 방식을 활용할 수 있습니다.

> *@sergeysova: 방법론을 기반으로 코드를 작성하는 개발자는 이미 많은 문제에 대한 해결책이 마련되어 있기 때문에, 문제 발생 빈도가 10배 정도 줄어듭니다.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마지막에 '줄어든다고 상상해보세요.'라고 붙여주는 것이 좋을 것 같습니다.

인용구이기 때문에 전체 맥락을 알수는 없지만 10배 줄어들었다고 확정적으로 말하는 문장은 아닌것 같네요.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 피드백 감사합니다. 반영했어요!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!

@movie42
Copy link
Contributor

movie42 commented Nov 22, 2024

Hello Maintainer,

I have completed the review of this translation, and the contributor has incorporated the suggested changes. Upon re-review, I did not find any issues. Please take a look when you have time.

Thank you!

@Gaic4o
Copy link
Contributor Author

Gaic4o commented Nov 24, 2024

@illright

@illright illright merged commit faf487c into feature-sliced:master Nov 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants