Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change usersAdapter to artistAdapter #763

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

frontend-sensei
Copy link
Contributor

Background

Just fixes typo in code example by replacing usersAdapter to artistAdapter
Documentation page:
https://feature-sliced.design/docs/guides/examples/types#how-to-deal-with-nested-dtos

Changelog

Here, usersAdapter is undefined and probably just wrong. So artistAdapter must be used
image

Copy link

netlify bot commented Nov 21, 2024

👷 Deploy request for pr-fsd pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ecb4f17

@illright
Copy link
Member

Good catch! I noticed also that there's .users in that line, which should be .artists. Could you change that too, please?

@frontend-sensei
Copy link
Contributor Author

frontend-sensei commented Nov 22, 2024

Good catch! I noticed also that there's .users in that line, which should be .artists. Could you change that too, please?

Thanks for your response! I also noticed, that in another langs same thing. Fixed.

Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@illright illright merged commit de27f36 into feature-sliced:master Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants