enhancement: Backticks Added for Layers on /get-started #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pr-fsd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
midas-png
changed the title
illright
requested changes
Dec 15, 2024
There was a problem hiding this comment.
Hi! These layer names were deliberately formatted as regular text with capital letters — it's to distinguish the name of the layer and the folder of that layer. This is also why the folders have a folder emoji included.
I do agree that the layer names could stand out a bit more, but I don't think code formatting is the way to go here. Maybe bold would look better?
|
I agree, bold indeed looks better. I've pushed the commit. Thanks!
|
illright
approved these changes
Dec 17, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
IMHO, the layer names look nondescript here.
Changelog
I suggest adding backticks to highlight the layers, just like it’s done on the same page with segments and the basic example