Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: layers page translated into Korean #787

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Gaic4o
Copy link
Contributor

@Gaic4o Gaic4o commented Jan 10, 2025

Background

I translated the svelteKit page into Korean.

If you think there are aspects that need improvement, please let me know, and I would be happy to make the adjustments. Thank you!

I have requested a Korean translation review from one reviewer in the FSD Discord Korean community to ensure that my Korean writing is well done. I would appreciate it if you could merge it after the review is completed.

@Gaic4o
Copy link
Contributor Author

Gaic4o commented Jan 27, 2025

I re-examined and revised the whole thing.


# Layer

Layer는 Feature-Sliced Design의 기본 구성 단위입니다. Layer의 주 목적은 코드의 책임 범위와 의존성을 기준으로 코드를 체계적으로 구조화하는 것입니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: how does "Layer는 Feature-Sliced Design의 기본 구성 단위입니다." translate?

Google Translate says it's "Layer is the basic building block of Feature-Sliced ​​Design.", and if so, I think we should clarify that it is the first of the three levels of organizational hierarchy (layer > slice > segment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the translation to better reflect the original meaning and hierarchy of Feature-Sliced Design. Clarified that layers are the top level in the Layer > Slice > Segment structure, rather than just 'basic building blocks.' Also refined the wording to highlight how layers define folder structures, helping organize functionality and manage dependencies more effectively.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@illright How do you feel about the revised parts? I’d appreciate your feedback

@Gaic4o Gaic4o requested a review from illright February 19, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants