Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINT-35(INTEGRATION): Move rule-configs close to tests #40

Merged
merged 4 commits into from
Dec 11, 2021

Conversation

Krakazybik
Copy link
Member

Description

Изменено: сгруппированы тесты и правила.
Добавлено: Немного документации с примерами и референсами на сайт.

Reference

#35

move helpers and utils to ./utils directory.
update mocha package.json run for new test locations.
@Krakazybik Krakazybik requested a review from azinit December 11, 2021 14:09
@Krakazybik Krakazybik self-assigned this Dec 11, 2021
@azinit
Copy link
Member

azinit commented Dec 11, 2021

фигасе шустрый)

@azinit azinit linked an issue Dec 11, 2021 that may be closed by this pull request
2 tasks
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит оч круто! Отдельное спасибо за нейминг PR/branch и описание 🚀

Есть пару toImprove моментов, а так - прям огонь

rules/layers-slices-boundaries/index.js Outdated Show resolved Hide resolved
rules/layers-slices-boundaries/index.md Show resolved Hide resolved
rules/layers-slices-boundaries/index.test.js Outdated Show resolved Hide resolved
rules/layers-slices-boundaries/index.test.js Outdated Show resolved Hide resolved
@Krakazybik Krakazybik requested a review from azinit December 11, 2021 17:22
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Можем вливать смело)

Спасиб за кропотливое отношение к toImprove комментам

Comment on lines +1 to +11
const { layersLib } = require("../../utils/layers");

const getLayersRules = () =>
FS_LAYERS.map((layer) => ({

layersLib.FS_LAYERS.map((layer) => ({
from: layer,
allow: getLowerLayers(layer),
allow: layersLib.getLowerLayers(layer),
}));

const getLayersBoundariesElements = () =>
FS_LAYERS.map((layer) => ({
layersLib.FS_LAYERS.map((layer) => ({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: 🔥🔥🔥

@Krakazybik Krakazybik merged commit 54604ae into master Dec 11, 2021
@Krakazybik Krakazybik deleted the refactor/LINT-35-move-rule-config branch December 11, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LINT(INTEGRATION): Move rule-configs close to tests
2 participants