-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LINT-35(INTEGRATION): Move rule-configs close to tests #40
Conversation
move helpers and utils to ./utils directory. update mocha package.json run for new test locations.
фигасе шустрый) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Выглядит оч круто! Отдельное спасибо за нейминг PR/branch и описание 🚀
Есть пару toImprove моментов, а так - прям огонь
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Можем вливать смело)
Спасиб за кропотливое отношение к toImprove комментам
const { layersLib } = require("../../utils/layers"); | ||
|
||
const getLayersRules = () => | ||
FS_LAYERS.map((layer) => ({ | ||
|
||
layersLib.FS_LAYERS.map((layer) => ({ | ||
from: layer, | ||
allow: getLowerLayers(layer), | ||
allow: layersLib.getLowerLayers(layer), | ||
})); | ||
|
||
const getLayersBoundariesElements = () => | ||
FS_LAYERS.map((layer) => ({ | ||
layersLib.FS_LAYERS.map((layer) => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise:
🔥🔥🔥
Description
Изменено: сгруппированы тесты и правила.
Добавлено: Немного документации с примерами и референсами на сайт.
Reference
#35