Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an exception if a non-existent folder is provided as an FSD root. #58

Closed
daniilsapa opened this issue Jul 16, 2024 · 4 comments · Fixed by #108
Closed

Throw an exception if a non-existent folder is provided as an FSD root. #58

daniilsapa opened this issue Jul 16, 2024 · 4 comments · Fixed by #108
Assignees
Labels
good first issue Good for newcomers PRIORITY | HIGH Important and significant TYPE | bug Something isn't working

Comments

@daniilsapa
Copy link
Collaborator

daniilsapa commented Jul 16, 2024

Right now it just says that no problems were found. But it seems the tool should exit with an error in this case, so the user can understand that they misconfigured the tool early.

Screenshot 2024-07-16 at 19 59 55
@illright illright added TYPE | bug Something isn't working PRIORITY | LOW Can wait until after release labels Jul 18, 2024
@illright
Copy link
Member

Indeed, that should be fixed! Ideally, we would also scan the folders around a given path in case it's a typo of 1-2 characters, and we could offer a suggestion to auto-correct the path

@daniilsapa
Copy link
Collaborator Author

Yes, I like the idea of scanning the folders and suggesting corrections to the path. It would be convenient and would improve DX. But I think it's a nice-to-have at the project's current stage. I propose to go with throwing the error first and simultaneously create an issue for the auto-correction enhancement, so we can revisit it later when more high-priority tasks are done.

@illright illright added the good first issue Good for newcomers label Sep 21, 2024
@illright illright added PRIORITY | HIGH Important and significant and removed PRIORITY | LOW Can wait until after release labels Oct 12, 2024
@illright
Copy link
Member

Upgrading the priority of this because it's very easy to build, yet will help out people who are trying to set up Steiger in their own projects

@illright
Copy link
Member

Btw, issue #40 is already tracking the auto-detection, I'll link it for context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers PRIORITY | HIGH Important and significant TYPE | bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants