Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw errors on non-existent paths #108

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Throw errors on non-existent paths #108

merged 1 commit into from
Oct 23, 2024

Conversation

illright
Copy link
Member

Closes #58

@illright illright requested a review from daniilsapa October 19, 2024 22:54
@daniilsapa
Copy link
Collaborator

Great updates! I don't have any suggestions or corrections. Just one question.

Why did you use these specific exit codes, 101 and 102? I did some googling about this, but I couldn't find any conventions about these exact codes for NodeJS or CLI tools in general. Are they something we create our own convention about? If so, should we keep track of such codes? Just create a document with an internal registry of such codes, so we know which codes are already taken and for what purpose

@illright
Copy link
Member Author

I just used some random codes that weren't used before. I don't think we need to keep track of them separately, because they're only in cli.ts for now, easy enough to remember.

If you don't have any objections, could you please approve? :) otherwise GitHub won't let me merge

@illright illright merged commit c6db720 into master Oct 23, 2024
7 checks passed
@illright illright deleted the nonexistent-path branch November 12, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw an exception if a non-existent folder is provided as an FSD root.
2 participants