Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path alias resolution #126

Merged
merged 3 commits into from
Nov 17, 2024
Merged

Conversation

daniilsapa
Copy link
Collaborator

Resolves #122

@daniilsapa daniilsapa requested a review from illright November 16, 2024 12:53
Copy link

changeset-bot bot commented Nov 16, 2024

🦋 Changeset detected

Latest commit: df783e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@feature-sliced/steiger-plugin Patch
steiger Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

illright
illright previously approved these changes Nov 16, 2024
Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice catch!

@illright
Copy link
Member

Why is the resolve needed?

@daniilsapa
Copy link
Collaborator Author

Because joinFromRoot just joins path segments and does not put the drive name at the beginning of the path (on Windows), which makes test cases fail on Windows

Screenshot 2024-11-16 at 15 09 27

@illright illright merged commit 9c1fec9 into master Nov 17, 2024
7 checks passed
@illright illright deleted the hotfix/fix-path-alias-resolution branch November 17, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.5.0 Validation and Link Reference Bugs
2 participants