Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #146

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Upgrade dependencies #146

merged 6 commits into from
Dec 19, 2024

Conversation

illright
Copy link
Member

@illright illright commented Dec 10, 2024

This was originally intended as a throw-away PR to try and break formatting and linting checks to verify that they work, but I noticed some config issues and decided to fix them, as well as upgrade all dependencies, something I wanted to do for a while

Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: ac2a9c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@illright illright changed the title break formatting Upgrade dependencies Dec 10, 2024
@illright illright requested a review from daniilsapa December 10, 2024 10:30
Copy link
Collaborator

@daniilsapa daniilsapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@illright
Looks great

I have only 2 questions:

  • Why did you add /packages and /tooling to .prettierignore?
  • I don't fully understand what caused the change of NodeJs version

(it's just interest, not complaints)

@illright
Copy link
Member Author

I added them to the ignore section of the root Prettier command because packages are responsible for their own formatting. That way, when we run turbo format, the commands don't overlap in the files that they scan.

As for the Node version change — we test on Node 18, so I updated the type definitions to include the APIs that are present in Node 18 so that we know upfront with TypeScript when something is not available in Node 18, but is available in a later version.

@illright illright merged commit 48fa255 into master Dec 19, 2024
7 checks passed
@illright illright deleted the formatting-errors branch December 19, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants