-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies #146
Upgrade dependencies #146
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@illright
Looks great
I have only 2 questions:
- Why did you add /packages and /tooling to .prettierignore?
- I don't fully understand what caused the change of NodeJs version
(it's just interest, not complaints)
I added them to the ignore section of the root Prettier command because packages are responsible for their own formatting. That way, when we run As for the Node version change — we test on Node 18, so I updated the type definitions to include the APIs that are present in Node 18 so that we know upfront with TypeScript when something is not available in Node 18, but is available in a later version. |
This was originally intended as a throw-away PR to try and break formatting and linting checks to verify that they work, but I noticed some config issues and decided to fix them, as well as upgrade all dependencies, something I wanted to do for a while