-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move getRuleDescriptionUrl to plugins #151
Conversation
🦋 Changeset detectedLatest commit: ff9ffe9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
About optionality — I think I would prefer it to be optional to lower the entry barrier for writing rules. It feels strange to link to documentation that doesn't yet exist, so we want to let people add the docs when it's convenient. If they don't have docs, they can always make the error message more descriptive |
Co-authored-by: Lev Chelyadinov <[email protected]>
Co-authored-by: Lev Chelyadinov <[email protected]>
Actually, optionality makes sense in this case. I think I'll change it a bit so that function can provide either a link or a short description for a diagnostic. Is that something you thought too? |
No, I meant that the explanation can be given in the error message itself. How would you like to display this short description that a function might return? |
I was thinking about a short description that could be returned by the |
…issing a description URL for the reporter
I made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
Closes #131
I was not sure about one thing: should
getRuleDescriptionUr
l be an optional plugin method or not? I decided to make it required because otherwise, a diagnostic is not that useful. What do you think?