Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an exception to the insignificant-slice rule when the only usage site is the App layer #154

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Add an exception to the insignificant-slice rule when the only usage site is the App layer #154

merged 1 commit into from
Dec 24, 2024

Conversation

illright
Copy link
Member

Closes #153

@illright illright requested a review from daniilsapa December 22, 2024 20:00
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2024

🦋 Changeset detected

Latest commit: 63eba55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@feature-sliced/steiger-plugin Patch
steiger Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

daniilsapa
daniilsapa approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@daniilsapa daniilsapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, approved, it's a good thing to include in 0.5.4

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 24, 2024

Open in Stackblitz

npm i https://pkg.pr.new/feature-sliced/steiger@154

npm i https://pkg.pr.new/feature-sliced/steiger/@steiger/toolkit@154

npm i https://pkg.pr.new/feature-sliced/steiger/@feature-sliced/steiger-plugin@154

commit: 63eba55

@illright illright merged commit 26130b5 into master Dec 24, 2024
13 checks passed
@illright illright deleted the insignificant-slice-app branch December 24, 2024 15:43
@illright illright mentioned this pull request Dec 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniilsapa daniilsapa daniilsapa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement an exception for the App layer in insignificant-slice
2 participants
@illright @daniilsapa