Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the rule set configurable with plugins #74

Merged
merged 10 commits into from
Aug 2, 2024
Merged

Make the rule set configurable with plugins #74

merged 10 commits into from
Aug 2, 2024

Conversation

daniilsapa
Copy link
Collaborator

Resolves #67

@daniilsapa
Copy link
Collaborator Author

@illright
I made it so that it uses the recommended default configuration from the FSD plugin if the configuration file is not found.

Also, question. Shouldn't we create a separate task to prepare a migration guide for the new config structure? Additionally, we could

  • create a script that would bring an old config to the new structure
  • support the previous config with warnings that it's outdated

@illright
Copy link
Member

illright commented Aug 1, 2024

Regarding the migration — good point, I forgot to make a task for it. I don't think we need to support the old format, since we're not 1.0 yet, but yes, providing a best-effort migration script will be useful. I'll make a task for it.

illright
illright requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great PR, I'm very happy with these changes! Just one blocker on my side

packages/steiger-plugin-fsd/src/index.ts Outdated Show resolved Hide resolved
packages/steiger/src/models/config.ts Show resolved Hide resolved
packages/steiger/src/app.ts Show resolved Hide resolved
@daniilsapa daniilsapa requested a review from illright August 2, 2024 18:20
@illright illright merged commit 997abb4 into feature-sliced:master Aug 2, 2024
7 checks passed
@illright
Copy link
Member

illright commented Aug 2, 2024

Great stuff!

@illright illright mentioned this pull request Aug 2, 2024
Closed
@daniilsapa daniilsapa deleted the feature/make-the-ruleset-configurable branch August 3, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illright illright illright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the rule set configurable with plugins
2 participants
@daniilsapa @illright