Log invalid input errors as error, not debug #31
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't seem like there's any way to ever enable debug logging in a real instance of this app, so things logged at debug level are effectively not logged at all. Anyway, these are errors, so it seems reasonable to log them as such. Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
I used this for debugging my openidc port, but honestly, it seems sensible to just do it. Surely we want to be able to debug any problems like this in future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't seem like there's any way to ever enable debug logging in a real instance of this app, so things logged at debug level are effectively not logged at all. Anyway, these are errors, so it seems reasonable to log them as such.