Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Category property #740

Closed
wants to merge 2 commits into from

Conversation

manfe
Copy link

@manfe manfe commented May 13, 2024

This adds the base property category that will be used to display queues organized by categories.

This is a split from the original PR: #739

@manfe manfe mentioned this pull request May 13, 2024
2 tasks
@felixmosh
Copy link
Owner

HI @manfe, can you add the UI usage of the category field in here?

@manfe
Copy link
Author

manfe commented May 16, 2024

@felixmosh you mean the code for the UI or an image example?

@felixmosh
Copy link
Owner

The code that actually makes the grouping by category in the UI (menu side bar)

@manfe
Copy link
Author

manfe commented May 17, 2024

@felixmosh can you review/merge #741 first, because the category feature (collapse/expand) depends heavily on that.

  1. When searching, all categories should expand;
  2. When clear search, collapse all categories.

Also, that PR makes the search results reflect to the overview page which is really good.

@felixmosh
Copy link
Owner

Grouping is not related to search, let's first merge grouping please.

@manfe
Copy link
Author

manfe commented May 17, 2024

Grouping is not related to search, let's first merge grouping, please.

It is related. Otherwise, I will need to centralize all the search into the Menu.tsx component and that will add unnecessary complexity to it.

The #741 splits the complexity and also makes it reflect on the overview page.

This entire context, depends on Search Provider.

But if you think that's a big issue, don't worry. I will keep the version that I am using in production already.

@felixmosh
Copy link
Owner

I don't get it.
Can you add the menu grouping by category? why is it related to the global search?

@manfe manfe closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants