Feat/sha and hash to field #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update upstream + add u512 mod p
feltroidprime
requested changes
Oct 16, 2024
Comment on lines
+53
to
+64
| def hex_to_chunks_32(hex_string: str): | ||
| # Remove '0x' prefix if present | ||
| if hex_string.startswith(('0x', '0X')): | ||
| hex_string = hex_string[2:] | ||
|
|
||
| # if we have an odd number of characters, prepend a 0 | ||
| if len(hex_string) % 2 == 1: | ||
| hex_string = '0' + hex_string | ||
|
|
||
| # Now split into 8-character (32-bit) chunks | ||
| chunks = [int(hex_string[i:i+8], 16) for i in range(0, len(hex_string), 8)] | ||
| return chunks |
There was a problem hiding this comment.
Use garaga.hints.io.bigint_split
It Works with bytes as well.
chunks = io.bigint_split(hasher.digest(), 8, 2**32)[::-1]
There was a problem hiding this comment.
super neat these functions!
There was a problem hiding this comment.
test keeps breaking, as I have variable length inputs, and need to compute n_limbs which keeps going wrong.
petscheit
force-pushed
the
feat/sha_and_hash_to_field
branch
from
2965790 to
342a217
Compare
petscheit
force-pushed
the
feat/sha_and_hash_to_field
branch
from
342a217 to
21457b9
Compare
feltroidprime
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information