-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): add vault provider #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this docs update!
A few grammatical suggestions while this is in draft (pending merge of spinframework/spin#798 as well)...
@flynnduism @mikkelhegn it looks like we're tracking changes to static/data.json
-- does this look right to you?
@vdice We are tracking |
@FrankYang0529 can you run |
2f2fe16
to
ac2275f
Compare
Hi @mikkelhegn, I run the command and committed it. I have a question: how to install |
Instructions are here: https://bartholomew.fermyon.dev/quickstart |
Thanks! I also add the reference to pull_request_template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested the functionality, but I trust the instructions are ok :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last thought: We don't yet have a good story around delineating between docs around unreleased Spin changes and docs that are valid for the most recent release (eg v0.6.0 currently). Until then, should we add a note somewhere that the vault config provider functionality is available in the canary
release now and anticipated to be included in the next v0.7.0 release?
(Filed #195 around docs versioning strategy)
Signed-off-by: Frank Yang <[email protected]>
Signed-off-by: Frank Yang <[email protected]>
62c2619
to
5622789
Compare
Added a note for it. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @FrankYang0529!
ref: spinframework/spin#798, spinframework/spin#661
Content must go through a pre-merge checklist.
Pre-Merge Content Checklist
This documentation has been checked to ensure that:
title,
template, and
date` are all setcat -ve <filename> | grep '^M' | wc -l
and expect 0 as a result)bart check
PREVIEW_MODE=1
and runnpm run styles
to update styling)npm run test
and resolved all errors