chore: migrate spin formula to spinframework/tap #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Hardock <[email protected]>
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "spin": "spinframework/tap" | |||
There was a problem hiding this comment.
I believe this needs to be the full repo path for the new tap
Suggested change
| "spin": "spinframework/tap" | |
| "spin": "spinframework/homebrew-tap" |
There was a problem hiding this comment.
I'm not sure; I was referencing https://github.com/Homebrew/homebrew-core/blob/master/tap_migrations.json and they seem to use cask. I think brew will auto inject the homebrew-. @kate-goldenring wdyt?
There was a problem hiding this comment.
That does seem to be the case! Here is another example https://github.com/Ensembl/homebrew-ensembl/blob/c6979849ed73d59efa32c8a044fa3bddc84f8e00/tap_migrations.json#L4.
kate-goldenring
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.