-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added HTTP webhook validation to spin SDK #502
Conversation
Signed-off-by: Jiaxiao Zhou <[email protected]>
Signed-off-by: Jiaxiao Zhou <[email protected]>
We have been discussing package organization and I think it would make sense for this to live in an outside repository. @michelleN suggests that a new Edit: We'll also probably move the redis trigger into a |
Oh! We were also discussing adding a "related projects" section to this repo's README, which would include a link to your repo. |
Is this spec used anywhere apart from CloudEvents? |
so far I haven't seen it being used in other places. |
Thanks a lot for the contribution, @Mossaka! It seems like it would make sense for this functionality to be part of a repo that was focused on adding CloudEvents support for Spin, rather than in the Spin repo itself. Then we can link the repo in the documentation and in the readme. |
@radu-matei yep I will move to spin-cloudevents repo. |
this PR adds the http webhook validation function to Spin SDK; The detailed specification for validation is written here.
This is the first PR to implement the Spin SIP #398 . See related discussion here #394