fixed ff_rosters() franchise_id for sleeper #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanho63
changed the title
tanho63
changed the title
|
Hmm. I don’t think this is the way to go, the roster id is needed in a couple of other places. I think you actually want to modify the sleeper_userleagues() function to have both roster id and owner id as columns |
|
okay, I added a new column roster_id to the output of sleeper_userleagues()
Technically the colname "franchise_id" is wrong, since it's actually the owner id. But I didn't changed it yet, because of compatibility. |
|
Thanks, that looks good! Can you bump the version number in DESCRIPTION and add a bullet to NEWS.md? I'll run the CI checks after that |
|
Done! |
tanho63
approved these changes
Sep 9, 2024
|
Thanks! Will address test failures separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #435
idk if it's the way you want to go. maybe add a second column istead of replace the old one? but i think that would not be coherent with the other platforms.