Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blueprint): selector combinator deserializing #200

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

fgardt
Copy link
Owner

@fgardt fgardt commented Feb 10, 2025

fixes #197

from serde docs:

flatten is not supported in combination with structs that use deny_unknown_fields. Neither the outer nor inner flattened struct should use that attribute.

-> we should add more tests for individual pieces of the BP data format instead of just the full test blueprints to properly verify the deserialized data is what we expect it to be

@fgardt fgardt enabled auto-merge (squash) February 10, 2025 23:59
@fgardt fgardt merged commit da720c9 into main Feb 11, 2025
9 checks passed
@fgardt fgardt deleted the fix/selector_combinator_bps branch February 11, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix blueprint combinator deserializing
1 participant