Add Global Controller Registration Support via filamentChartJsRegister
#15822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a mechanism for globally registering Chart.js controllers and elements using a new global array:
window.filamentChartJsRegister
. Currently, Filament's chart implementation supports adding additional plugins viawindow.filamentChartJsPlugins
passed in the chart configuration. However, this method does not support registering new controllers—such as those required for treemap charts—which must be registered globally usingChart.register()
.With this change, before initializing a chart, the code checks if
window.filamentChartJsRegister
is defined and contains any entries. If so, it registers these controllers/elements globally viaChart.register(...window.filamentChartJsRegister)
. This ensures that custom controllers, which cannot be registered via the plugins array, are available for use without affecting existing functionality.Visual changes
No visual changes are expected. The modification only impacts the chart initialization process to support additional controller registration. Charts that rely on custom controllers (e.g., treemap charts) will now render correctly.
Functional changes
composer cs
command.