PDP service contract whitelist #545
Conversation
|
cc @rvagg |
|
|
||
| // Check if the recordkeeper is in the whitelist | ||
| for _, allowed := range allowedList { | ||
| if recordKeeper == allowed { |
There was a problem hiding this comment.
Do you know if common.Address is going to be happy with case-insensitive forms of the address? Should we just lower-case all addresses to avoid any issues with case sensitivity and not demand the user provide the correct validation form?
There was a problem hiding this comment.
Good question. After looking into it the answer is that case insensitivity is handled correctly.
Tracing through common.Address everything relies in a straightforward way on golang stdlib hex encode decode. Stdlib reverse lookup from ascii code to hex value is here: https://cs.opensource.google/go/go/+/refs/tags/go1.24.4:src/encoding/hex/hex.go;l=25 and you can see capital letters are treated correctly.
I see where you're coming from but since it only applies to the public service I am ok with leaving it as a build constant like the existing verifier. Merging synapse back to main will require some conceptual merging of the public service construct and we can revisit this question then as part of that. |
This provides some protection for curio PDP operators running publically accessible PDP services. Only the pandora PDP service contract is allowed upon proofset creation over the publically available PDP service.
The whitelist is network dependent -- only calibnet specified as pandora only launched on calibnet.