-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix: Fixed an issue where the home key wouldn't move focus when renaming items #17127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed an issue where the home key wouldn't move focus when renaming items #17127
Conversation
Did you mean to link to #14253? |
@AkhilReddy-Ramireddy Please link to the correct issue, #14253 is a PR |
Hi @Lamparter, thanks for checking! Yes, the PR description correctly links to issue #14253. I've also updated the PR title to remove any confusion. |
@AkhilReddy-Ramireddy can you please update the PR description with the correct issue link and steps used to verify these changes? Thank you! |
#15048 is the correct issue that this PR should link to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this PR fixes #15048
This commit addresses the issue where pressing the Home key during file renaming in List View (and other views inheriting from BaseGroupableLayoutPage) did not move the cursor to the absolute beginning of the filename if the filename was longer than the visible TextBox. The fix ensures that textBox.SelectionStart is set to 0 and textBox.SelectionLength is set to 0 when the Home key is pressed, providing behavior consistent with Windows Explorer.
f8d51df
to
ca8a74e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit addresses the issue where pressing the Home key during file renaming in List View (and other views
inheriting from BaseGroupableLayoutPage) did not move the cursor to the absolute beginning of the filename if the
filename was longer than the visible TextBox. The fix ensures that textBox.SelectionStart is set to 0 and
textBox.SelectionLength is set to 0 when the Home key is pressed, providing behavior consistent with Windows
Explorer.
Resolved / Related Issues
Resolves #15048