Code Quality: Refactor MeasureOverride method to early exit for null or empty context #17483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR Prevents throwing a NullReferenceException when context or context.Childrenis null, there's no null checking. |
0x5bfa
suggested changes
Aug 24, 2025
Comment on lines
+34
to
+37
| if (context?.Children == null || context.Children.Count == 0) | ||
| { | ||
| return new Size(0, 0); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (context?.Children == null || context.Children.Count == 0) | |
| { | |
| return new Size(0, 0); | |
| } | |
| if (context?.Children is null || context.Children.Count is 0) | |
| return new Size(0, 0); |
| _availableSize = availableSize; | ||
|
|
||
| var indexAfterEllipsis = GetFirstIndexToRender(context); | ||
| var maxHeight = 0; | ||
| var totalWidth = 0; | ||
| var children = context.Children; |
|
|
||
| return accumulatedSize; | ||
| return new Size(totalWidth, maxHeight); |
There was a problem hiding this comment.
Why you don't use Size instead, like I did? And I feel like the code changes in the middle are unnecessary, is there a reason why you change there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.