-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build gcc with current Homebrew patches and remove lib*san on Ventura #1033
base: master
Are you sure you want to change the base?
Conversation
Thanks for working this. %r needs to be bumped because there are changes in the build (like all the PIE things) that affect the end result. |
Of course, and 11.4.0-1 is already in...
Not aware of any packages, and admittedly I don't know about their exact usage. The documentation has not seen much activity, but the code is still getting some updates merged in from LLVM. So as long as some users might have a use for them, I thought as long as they build we may as well distribute them. |
c912034
to
29cb0bf
Compare
Rebased this, leaving the libsanitizer build enabled for arm64 – I have tested some of the example functions from |
29cb0bf
to
920724f
Compare
I tested this PR on Big Sur with Xcode 13, but got these results:
|
Right; forgot that Xcode 14 again will not be available at older macOS versions – so that would need another separate build for 12.0; or since the requirement is just for the libsanitizer build on arm64, restrict it to that. |
6723e51
to
6c81990
Compare
OK thanks, I can confirm that 6c81990 fixed this.
My machine is x86_64, so I wouldn't know... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to build this PR successfully on x86_64 Big Sur with Xcode 13; it's probably good to go.
This PR allows build of gcc 11 on MacOS 13.6 (Ventura) X86_64 with Xcode 15.0 and associated CLT. |
@nieder can you approve? |
Building the AddressSanitizer and ThreadSanitizer tools libasan and libubsan is broken on macOS >= 13 and has thus been disabled in the latest gcc branches:
iains/gcc-darwin-arm64@e722a1f4
Those files are therefore missing from the shlibs SplitOff, accommodated in a separate .info for
Distribution: 13.0
(for lack of an easier way to handle this for now). Also pulling in the current patches from the gcc arm64 team copied from Homebrew.Tested on 12.7 and 13.4 arm64 and x86_64/Rosetta, and on 10.14.6 x86_64; should especially be tested on 13.x and 14.x with Xcode 15; if this is an acceptable solution, the gcc updates for 12.3.0 and 13.1.0 can be handled in the same way.