-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patches/updates for building with python3 on 12.0+ #945
base: master
Are you sure you want to change the base?
Conversation
you should be breaking this up so maintainers can approve their own. There are too many here for me to test, I'll cherry pick the ca-certs change later today. |
Thanks; not sure how many maintainers have 12.x or 13.1 to test on (in fact most of the other packages have None or the Gnome Team). 8ea266b has the rather straightforward changes. |
Note that zziplib here uses the upstream update rather than the patch from 9568691. |
zziplib decreased compatibility_version when they switched from autotools to cmake. This is a no-go because anything linking it will break if we update zziplib. |
itstool doesn't just need a defined python interp at runtime, but it also needs to have libxml2-pyXX to match it, so we have to use fink's python interp (as the package already does). No objection to bumping it to use python310 instead of python27, but that seems a separate issue from trying to cope with /usr/bin/python version-changes. Note that changing a Depends always requires changing %r. |
I agree both that %r should have been updated, and it does not really belong with the systempython updates; I had only included it here as I was unable to build python27 on arm64. As @TheSin- has been successful with that and seems close to open a PR closing #956, we could also just keep it as is for now (although generally I'd vote for using a still supported Python version). |
<< | ||
NoSetCPPFLAGS: true | ||
NoSetCFLAGS: true | ||
NoSetCXXFLAGS: true | ||
SetCXXFLAGS: -std=gnu++99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"gnu++99
" isn't an actual standard; typo for "gnu++98
"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SetCXXFLAGS: -std=gnu++99 | |
SetCXXFLAGS: -std=gnu++98 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably confused with c99/gnu99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably confused with
c99/gnu99
yeah that's what I was guessing
Various packages tested on 12.6.1 and mostly also on 13.1, for backward compatibility on 10.14.
edit to add list of packages in this PR and their status: