Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show appropriate date when date is part of grouped data on chart. #2857

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

onesimus-wiafe
Copy link
Contributor

@onesimus-wiafe onesimus-wiafe commented Nov 19, 2024

This PR addresses issue #2566. When the data is grouped and a date is part of the grouped data, the date values are then represented in epoch format. I couldn't figure out the exact source of the problem, and this solution addresses the problem. I included a function in the filter.ts file since all the plugins affected by this issue import the functions in filter.ts. I refine the date type values before the functions in filter.ts run. The tests included confirm this solution too.

Pull Request Checklist

  • Description which clearly states what problems the PR solves.
  • Description contains a link to the Github Issue, and any relevent
    Discussions, this PR applies to.
  • Include new tests that fail without this PR but passes with it.
  • Include any relevent Documentation changes related to this change.
  • Verify all commits have been signed in accordance with the DCO policy.
  • Reviewed PR commit history to remove unnecessary changes.
  • Make sure your PR passes build, test and lint steps completely.

@onesimus-wiafe onesimus-wiafe force-pushed the plugin/fix_epoch_time_to_date_on_axis_label branch from d23bc03 to 2f967db Compare November 25, 2024 18:18
Signed-off-by: Onesimus Wiafe <[email protected]>
Signed-off-by: Onesimus Wiafe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chart Plugin] Multi-tier grouping by date displays epoch time in axis label
2 participants