shows the right tooltip for the correct cell the cursor hovers over #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
this matches the behavior pre-toolchain patch -- if PSP_ARCH is not set, then no toolchain file is defined, and the build proceeds without setting `CMAKE_OSX_ARCHITECTURES` Signed-off-by: Tom Jakubowski <[email protected]>
macos-14 is aarch64 with Apple silicon. This lets us test the aarch64 wheel in CI Will try a follow up to see if the builds are any faster on macos-14. Will want to double check we still have a good value for `CMAKE_OSX_DEPLOYMENT_TARGET`/`MACOSX_DEPLOYMENT_TARGET` after upgrading the builders Signed-off-by: Tom Jakubowski <[email protected]> new crack at build matrix verified this one with a model of the behavior in github's docs. would be cool if I knew how to get github to print the job configurations before the job actually runs
Signed-off-by: Timothy Bess <[email protected]>
Signed-off-by: Albert Kyei <[email protected]>
Signed-off-by: Albert Kyei <[email protected]>
Signed-off-by: Albert Kyei <[email protected]>
Signed-off-by: Albert Kyei <[email protected]>
aiohttp will throw if the handler doesn't return anything.
```python
14:11:35 aiohttp ERRO Missing return statement on request handler
Traceback (most recent call last):
File "/Users/steve/conda/envs/port/lib/python3.12/site-packages/aiohttp/web_protocol.py", line 653, in finish_response
prepare_meth = resp.prepare
^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'prepare'
```
https://docs.aiohttp.org/en/stable/web_quickstart.html#websockets
Signed-off-by: Steve Chan <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
This updates the perspective-python build to create an sdist tarball by hand, not going through `maturin sdist`. This bypasses some issues we have seen with Maturin mispackaging the perspective Cargo workspace in the sdist. Maturin is still used as the `build-backend` to build a wheel from the sdist. CI still uses `maturin build` to build wheels. Local development builds still use `maturin develop`. The sdist now includes the .data directory so that Maturin will place it in the wheel correctly. Building an sdist with PSP_BUILD_SDIST=1 will now error if it appears the jupyterlab plugin was not built into the .data directory. Most of the work is in generating a PKG-INFO file. Its output matches what's in the 3.1.2 sdist on pypi, minus a correction to fix the `Home-page` field miscapitalized by Maturin and some unimportant whitespace changes in `Require-Dist`. Signed-off-by: Tom Jakubowski <[email protected]>
caveat: a ~/.cargo/config.toml file is created when testing the sdist which patches the perspective-python build so that it uses perspective-server and perspective-client from the local git checkout. This is so we can test unreleased changes to those crates together, without including the client/server source in the sdist. Builders who download sdist artifacts produced in CI between releases may find they don't build or work correctly, since those sdists will contain dependencies on release versions of perspective-server and perspective-client published to crates.io. Signed-off-by: Tom Jakubowski <[email protected]>
Signed-off-by: Andrew Stein <[email protected]> # Conflicts: # rust/perspective-python/Cargo.toml
fixes bug when cmake is installed to a path with a space in it Signed-off-by: Tom Jakubowski <[email protected]>
Also updates the cargo patch-job so it uses the .crate files produced earlier in the workflow instead of using git sources with metadata. This is closer to what happens when building and installing from a release sdist, which pulls .crate files from crates.io. Signed-off-by: Tom Jakubowski <[email protected]>
Change how the CMAKE_C_FLAGS_RELEASE and CMAKE_CXX_FLAGS_RELEASE variables are reset and used. They are now interpolated into CMAKE_CXX_FLAGS, placed before the EXTENDED_FLAGS so that EXTENDED_FLAGS and OPT_FLAGS can override the FLAGS_RELEASE. This ensures that RELEASE flags from the environment are used, while allowing them to be overridden by perspective's optimization flags. Also preserve values of `CMAKE_CXX_FLAGS` set by the builder. This is a port of a conda-feedstock patch by Isuru Fernando. <conda-forge/perspective-feedstock@9eab18c> Signed-off-by: Tom Jakubowski <[email protected]>
Signed-off-by: Tom Jakubowski <[email protected]>
this was an ODR violation: the same function was defined twice, once with `inline` specifier in utils.h, and once without `inline` in utils.cpp it happened to work on clang and gcc and msvc, most of the time, but broke in the conda build on Windows Signed-off-by: Tom Jakubowski <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
….Table Signed-off-by: Tim Paine <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Albert Kyei <[email protected]>
Signed-off-by: Albert Kyei <[email protected]>
Signed-off-by: Albert Kyei <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Tim Paine <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Tom Jakubowski <[email protected]>
Signed-off-by: Tom Jakubowski <[email protected]>
Signed-off-by: Arash Partow <[email protected]>
…__all__` Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Tim Paine <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Tim Paine <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
…tion disableable Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
…atapoint from left Signed-off-by: Tarek Quao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue #2340 where the heatmap chart shows tooltips for the wrong cell; specifically the nearest cell to the right when the cursor moves halfway in the "right" direction
#2340