feat(rc): Sever Side Remote Config Integration #863
+1,788
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial Skeleton for SSRC Implementation * Adding Implementation for RemoteConfigApiClient and ServerTemplate APIs * Updating API signature * Minor update to API signature * Adding comments and unit tests * Updating init params for ServerTemplateData * Adding validation errors and test * Adding unit tests for init_server_template and get_server_template * Removing parameter groups * Addressing PR comments and fixing async flow during fetch call * Fixing lint issues --------- Co-authored-by: Pijush Chakraborty <[email protected]>
…e Remote Config (#824) * Added implemenation of evaluate function * Improvement * Add farmhash to extension whitelist pkg * Replace farmhash to hashlib * Added unit testcase * removed lint error * add mock test * resolve lint comments * Fixed bug * Added fixes * Added fixe * Added fix for lint * Changed structure of test * Added fix for comments * Added fix for comments --------- Co-authored-by: Varun Rathore <[email protected]>
* Changes for percent comparison * Fixing semantic version issues with invalid version * Fixing Config values must retrun default values from invalid get operations * Updating tolerance for percentage evaluation * Removing dependency changes from fix branch * Updating ServerConfig methods as per review changes * Updating comments and vars for readability * Added unit and integration tests * Refactor and add unit test * Implementation for Fetching and Caching Server Side Remote Config (#825) * Minor update to API signature * Updating init params for ServerTemplateData * Adding validation errors and test * Removing parameter groups * Addressing PR comments and fixing async flow during fetch call * Fixing lint issues --------- Co-authored-by: Jonathan Edey <[email protected]> Co-authored-by: Lahiru Maramba <[email protected]> Co-authored-by: Pijush Chakraborty <[email protected]> Co-authored-by: varun rathore <[email protected]> Co-authored-by: Varun Rathore <[email protected]>
…d the value source of the config values (#850) * Updating ServerTemplate to accomodate to_json() method * Updating unit tests and docstrings * Adding re-entrant lock to make template cache updates/reads atomic --------- Co-authored-by: Pijush Chakraborty <[email protected]>
* Fixing percentage lowebound issues * Updating logs * Fixing lint issues --------- Co-authored-by: Pijush Chakraborty <[email protected]>
lahirumaramba
changed the title
Fixed typos in comments and added additional description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.