Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataconnect: demo: make codegen gradle task cacheable #6571

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Dec 6, 2024

firebase-dataconnect/demo/build.gradle.kts: make DataConnectGenerateSourcesTask cacheable to demonstrate making a task cacheable, and, in theory, could speed up incremental builds.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

github-actions bot commented Dec 6, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 6, 2024

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 6, 2024

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Test Results

   62 files   -    974     62 suites   - 974   1m 13s ⏱️ - 31m 39s
  541 tests  -  5 332    540 ✅  -  5 311  1 💤  - 21  0 ❌ ±0 
1 082 runs   - 10 749  1 080 ✅  - 10 707  2 💤  - 42  0 ❌ ±0 

Results for commit 8987469. ± Comparison against base commit 11403df.

This pull request removes 5332 tests.
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

♻️ This comment has been updated with latest results.

@dconeybe dconeybe closed this Dec 6, 2024
@dconeybe dconeybe deleted the dconeybe/dataconnect/demoapp_caching branch December 6, 2024 21:32
@dconeybe dconeybe restored the dconeybe/dataconnect/demoapp_caching branch December 6, 2024 21:50
@dconeybe dconeybe reopened this Dec 6, 2024
@dconeybe dconeybe merged commit 4abf678 into main Dec 7, 2024
41 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/demoapp_caching branch December 7, 2024 05:17
@firebase firebase locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants