-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: sort strings in UTF-8 encoded byte order #6615
Conversation
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-firestore### {{firestore}} version 25.1.2 {: #firestore_v25-1-2}
* {{fixed}} Fixed a server and sdk mismatch in unicode string sorting. GitHub [#6615](//github.com/firebase/firebase-android-sdk/issues/6615){: .external}
#### {{firestore}} Kotlin extensions version 25.1.2 {: #firestore-ktx_v25-1-2}
The Kotlin extensions library transitively includes the updated
`firebase-firestore` library. The Kotlin extensions library has no additional
updates.
|
Vertex AI Mock Responses Check
|
Test Results 186 files + 144 186 suites +144 4m 19s ⏱️ + 2m 57s Results for commit 4987548. ± Comparison against base commit b5dbd0a. This pull request removes 322 and adds 1234 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
Strings should be sorted in UTF-8 encoded byte order. Public document: https://cloud.google.com/firestore/docs/concepts/data-types#data_types
SDK sorts strings using built in comparator method, which sorts lexicographically, and leads to mismatch between server and sdk when special characters are present. This PR fixes the string order mismatches on document field, map key, and document key.