Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CHANGELOG for Crashlytics to better document the changes. #6623

Closed
wants to merge 4 commits into from

Conversation

tejasd
Copy link
Contributor

@tejasd tejasd commented Jan 13, 2025

The SDK contains a new API which was added in #6528.

Since it's a new API, this should be a minor version bump, and not a patch.

Edit: This is an API overload that's backwards compatible and so it's probably OK for it to be a patch release.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-crashlytics
### {{crashlytics}} version 19.3.1 {: #crashlytics_v19-3-1}

* {{fixed}} Added an overload for `recordException` that allows logging event specific custom keys. 
  (GitHub [#3551](//github.com/firebase/firebase-android-sdk/issues/3551){: .external})

#### {{crashlytics}} Kotlin extensions version 19.3.1 {: #crashlytics-ktx_v19-3-1}

The Kotlin extensions library transitively includes the updated
`firebase-crashlytics` library. The Kotlin extensions library has no additional
updates.

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.3

@tejasd tejasd requested a review from davidmotson January 13, 2025 20:43
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 13, 2025

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Test Results

 8 files   -  34   8 suites   - 34   19s ⏱️ - 1m 3s
22 tests  - 300  22 ✅  - 300  0 💤 ±0  0 ❌ ±0 
44 runs   - 612  44 ✅  - 612  0 💤 ±0  0 ❌ ±0 

Results for commit 39dec30. ± Comparison against base commit b5dbd0a.

This pull request removes 322 and adds 22 tests. Note that renamed tests count towards both.
com.google.firebase.remoteconfig.ConfigTests ‑ Custom Signals builder support multiple types
com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance()
com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance(FirebaseApp, region)
com.google.firebase.remoteconfig.ConfigTests ‑ FirebaseRemoteConfigSettings builder works
com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns default value when key doesn't exist
com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns value when key exists
com.google.firebase.remoteconfig.CustomSignalsTest ‑ testCustomSignals_builderPutDouble
com.google.firebase.remoteconfig.CustomSignalsTest ‑ testCustomSignals_builderPutDuplicateKeys
com.google.firebase.remoteconfig.CustomSignalsTest ‑ testCustomSignals_builderPutLong
com.google.firebase.remoteconfig.CustomSignalsTest ‑ testCustomSignals_builderPutMixedTypes
…
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testDefaultDataCollection_usedWhenNoOverrideOrManifestSetting
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testManifestMetadata_respectedWhenNoOverride
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testSetCrashlyticsDataCollectionEnabled_overridesOtherSettings
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 13, 2025

@tejasd tejasd changed the title Fix the version of the Crashlytics SDK to 19.4.0 Update the CHANGELOG for Crashlytics to better document the changes. Jan 13, 2025
@tejasd tejasd closed this Jan 14, 2025
@tejasd tejasd deleted the td/version-bump branch January 14, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants